feat: remove cache in static length poseidon2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Jan 13, 2026
TomAFrench
reviewed
Jan 13, 2026
Comment on lines
+69
to
+74
| for i in 0..in_len { | ||
| state[i % RATE] += input[i]; | ||
| if (i + 1) % RATE == 0 { | ||
| state = crate::poseidon2_permutation(state, 4); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This should be done in a followup but I'd like to explore us partially unrolling this so that we writes into the state array 4 at a time to avoid needing to do so many modulos.
Member
There was a problem hiding this comment.
Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When message size is given, there is no need to use cache to track absorb vs squeeze.
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.